Release v0.8.5#39
Merged
albertomandlate merged 7 commits intomainfrom May 22, 2025
Merged
Conversation
Mudou a propriedade `Indent` de `true` para `false` na configuração do `XmlWriterSettings`. Isso resulta em uma saída XML mais compacta, sem indentação.
Alterar configuração de indentação do XML
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements localization for CodeQL workflow steps in Portuguese and disables XML indentation in the SAF-T Mozambique generator to streamline output size.
- Localized CodeQL job and step names to Portuguese for consistency.
- Changed
XmlWriterSettings.Indentfromtruetofalseto produce compact XML.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs | Disabled XML indentation in XmlWriterSettings |
| .github/workflows/codeql.yml | Translated job and step name fields to Portuguese |
| exit 1 | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| - name: Fazendo analises com o CodeQL |
There was a problem hiding this comment.
The Portuguese word "analises" is missing an accent; consider changing to "Fazendo análises com o CodeQL".
Suggested change
| - name: Fazendo analises com o CodeQL | |
| - name: Fazendo análises com o CodeQL |
| XmlWriterSettings settings = new() | ||
| { | ||
| Indent = true, | ||
| Indent = false, |
There was a problem hiding this comment.
[nitpick] Consider making the indentation setting configurable or at least adding a comment explaining why indentation is disabled to improve future maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes localization updates to the CodeQL workflow file and a minor adjustment to XML writer settings in the Mozambique SAF-T generator. Below is a summary of the most important changes:
Localization updates in
.github/workflows/codeql.yml:XML writer settings adjustment in
MozambiqueSaftGenerator.cs:Indentproperty inXmlWriterSettingsfromtruetofalse, likely to reduce the size of the generated XML files.